8000 Display lower <1 s/vB fee rate tiers for Liquid by softsimon · Pull Request #910 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Display lower <1 s/vB fee rate tiers for Liquid #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

Display lower <1 s/vB fee rate tiers for Liquid #910

merged 1 commit into from
Nov 17, 2021

Conversation

softsimon
Copy link
Member

fixes #859

This PR does:

  • Liquid fee ranges 0.1, 0.2, 0.3 sat/vB etc are now stored in the 1, 2, 3 respective database fields
  • The frontend adapt and display 1/10 the size of fee levels

Screen Shot 2021-11-09 at 23 55 33

e

@knorrium
Copy link
Member

@softsimon did you test this on the main dashboard as well to make sure limitFeesTemplate is correct based on the view?

mempool/frontend/src/app/components/mempool-graph/mempool-graph.component.ts

Lines 88 to 91 in 26a540a

let limitFeesTemplate = this.template === 'advanced' ? 28 : 21;
if (this.stateService.network === 'liquid') {
limitFeesTemplate = this.template === 'advanced' ? 26 : 20;
}

@softsimon
Copy link
Member Author

@softsimon did you test this on the main dashboard as well to make sure limitFeesTemplate is correct based on the view?

mempool/frontend/src/app/components/mempool-graph/mempool-graph.component.ts

Lines 88 to 91 in 26a540a

let limitFeesTemplate = this.template === 'advanced' ? 28 : 21;
if (this.stateService.network === 'liquid') {
limitFeesTemplate = this.template === 'advanced' ? 26 : 20;
}

Yes, the main dashboard is affected as well.

@MiguelMedeiros
Copy link
Contributor

Tested ACK.

Suggestion: Maybe you could make the decimal cases of the labels fixed to 1 for all labels, example:
0.8 - 1.0, 1.0 - 1.2, etc

BASE_MODULE='liquid'.

Preview

image

@knorrium I've also tested with the BASE_MODULE='mempool'.

Preview

image

@wiz wiz self-assigned this Nov 17, 2021
wiz
wiz approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ 26a540a
Seems okay, but often the fee rate tier has < 0.01 MvB of transactions and gets rounded off to 0 which we probably want to fix in the future...

@wiz wiz merged commit 6ad4e65 into master Nov 17, 2021
@wiz wiz deleted the simon/liquid-fee-ranges branch November 17, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@MiguelMedeiros MiguelMedeiros MiguelMedeiros approved these changes

Assignees

@wiz wiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display lower <1 s/vB fee rate tiers for Liquid Network
4 participants
@softsimon @knorrium @MiguelMedeiros @wiz
0