8000 Adding Taproot transaction tag by softsimon · Pull Request #918 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding Taproot transaction tag #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2021
Merged

Adding Taproot transaction tag #918

merged 1 commit into from
Nov 10, 2021

Conversation

softsimon
Copy link
Member

fixes #914

This PR:

  • Adds a Taproot tag with tooltip, on detection
  • Treat Taproot-outputs like native segwit to display Segwit and savings

Screen Shot 2021-11-10 at 15 09 16

@softsimon softsimon requested review from knorrium and wiz November 10, 2021 11:10
wiz
wiz approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ 88e48df

@wiz
Copy link
Member
wiz commented Nov 10, 2021

Works well using TXIDs:
Testnet: 529a89a4daadef5e889a97761bc0697f1a5bd74c11a7466908b820659fd52bfc
Signet: 24083fdac05edc9dbe0bb836272601c8893e705a2b046f97193550a30d880a0c

@wiz wiz merged commit 61ffcd0 into master Nov 10, 2021
@wiz wiz deleted the simon/taproot-tag branch November 10, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@knorrium knorrium Awaiting requested review from knorrium

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Taproot] Add a Taproot tag similar to SegWit and RBF
2 participants
@softsimon @wiz
0