8000 refactor: small feedback improvement on local-dns installation by augustoccesar · Pull Request #220 · mentimeter/linkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: small feedback improvement on local-dns installation #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

augustoccesar
Copy link
Collaborator

No description provided.

@augustoccesar augustoccesar requested a review from Copilot March 31, 2025 09:42
@augustoccesar augustoccesar self-assigned this Mar 31, 2025
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines error handling for loading Firefox profiles by only printing an error message when the error kind is not NotFound, and adds confirmation print statements to the local DNS install and uninstall commands.

  • Only print error for non-NotFound errors when loading Firefox profiles.
  • Add console feedback for local DNS installation and uninstallation.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
local-server/src/certificates/mod.rs Added conditional error printing for Firefox profiles.
linkup-cli/src/commands/local_dns.rs Added output messages for installation/uninstallation confirmation.

@augustoccesar augustoccesar changed the title feat: only print error if is not NotFound for Firefox feat: small feedback improvement on local-dns installation Mar 31, 2025
@augustoccesar augustoccesar requested review from ostenbom and a team March 31, 2025 09:43
@augustoccesar augustoccesar changed the title feat: small feedback improvement on local-dns installation refactor: small feedback improvement on local-dns installation Mar 31, 2025
@augustoccesar augustoccesar marked this pull request as ready for review March 31, 2025 09:55
@augustoccesar augustoccesar merged commit 3bd7e93 into next Mar 31, 2025
6 checks passed
@augustoccesar augustoccesar deleted the augustoccesar/improve-feedback-on-local-dns-installation branch March 31, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0