Skip instrumenting primitive fns #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
requested changes
Mar 13, 2025
8000
docs/function-schemas.md
Outdated
| @@ -509,6 +509,8 @@ Turning instrumentation on: | |||
| ; =throws=> :malli.core/invalid-output {:output [:int {:max 6}], :value 11, :args [10], :schema [:=> [:cat :int] [:int {:max 6}]]} | |||
| ``` | |||
|
|
|||
| Note that functions with JVM primitive param or return type hints will not be instrumented. | |||
There was a problem hiding this comment.
should the bb exception be mentioned here?
There was a problem hiding this comment.
I know bb won't create a primitive function, but I'm not sure if it can reach vars that contain them. I changed the documentation to be more specific to handle that.
opqdonut
approved these changes
Mar 14, 2025
|
sorry for the delay in merging 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #859
Throwing seems too disruptive given that it's common to instrument everything.
Other changes:
-find-vartest to the outside so-filter-varnever fails to pass a var-find-nsset for improved performance