Cache validators recursively #1180
Conversation
|
There's something bugging me about the dynamism being lost here. For example, does this interfere with dynamically scoped registries in a way that matters? |
I think it does. I would assume that I can recreate a schema validator with current bindings when calling |
I'm not sure that holds even today, the caching of (ns malli.registry-test
(:require [clojure.test :refer [deftest is testing]]
[malli.core :as m]
[malli.registry :as mr]))
(let [registry* (atom {})
register! (fn [t ?s] (swap! registry* assoc t ?s))
registry (mr/composite-registry
{:map (m/-map-schema)}
(mr/mutable-registry registry*)
(mr/dynamic-registry))
_ (register! :maybe (m/-maybe-schema))
s (binding [mr/*registry* {::foo (m/-string-schema)}]
(m/schema [:map [:maybe [:maybe ::foo]]] {:registry registry}))]
(binding [mr/*registry* {::foo (m/-int-schema)}]
(is ((m/-validator s) {:maybe "sheep"}))
(is (not ((m/-validator s) {:maybe 1})))))EDIT: it later occurred to me this probably isn't |
|
We discussed this with Tommi & some Metosin guys. We don't feel good about this PR for a couple of reasons:
|
In some cases, we can save a lot of work and memory by pushing in the
-cachedlogic further into the schemas. The tests demonstrate a key use-case: a schema that is only ever used as a child.This is the output of the final line of the test on master:
{:-validator 10, :-parser 10, :-unparser 10, :-explainer [[0] [0]]}i.e., this PR saves 27 calls to protocol methods, each returning fresh fns.
Moving the
explainercache to the entire fn also saves recreating the fn every call.