Reduce CLJS compiled bundle size #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change welcome. |
|
Hm, I'm actually struggling to make it work on CLJS with all the macro action that is going on. Will you accept a PR that spells out all pairs of symbols and function values explicitly? I know it's more error prone this way, but I'm not sure I can make this work in the way I wanted from the beginning. |
96b0c4c to
371fa43
Compare
|
Alright, managed to get it to work by extracting the code-expanding macro into another namespace. I'm not sure why it couldn't work within the same namespace, I don't have that much experience with CLJS. |
|
Great, thanks! If you want smaller cljs bundles, there is also the compiler option to omit the default registry: https://github.com/metosin/malli?tab=readme-ov-file#dce-and-schemas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Clojurescript compiler encounters a call to
resolveor avarmacro, it inlines the whole metadata right at the callsite. This produces a lot of unnecessary code in the compiled output.My proposal here is to rewrite
predicate-schemasfunction to avoid using#'quoting. With these changes, I was able to reduce the compiled Malli size (with advanced optimizations) by 14 KB uncompressed (4KB gzipped).