Add dotenv, remove redundant LOC, fix encoding problem, change URLs to ERP3 #2
Conversation
- try to make all the requests that are shown in the dev console network tab and thus emulate the browser - doesn't seem to work for now
|
Thanks for the fixes :) I see some debugging print statements, and commented out code - that can be cleaned up? |
|
Yes, thanks! You are right. I am keeping the Login print statements, because they tell us about whether the login was completed or not. Everything else I'll remove. |
|
@nishnik The fact that it works tells us that they are obviously not checking that particular parameter. Most probably, they are just ignoring that header, and even if they are using it, they are simply checking the domain name, which happens to match I will test if this works after removing the parameters one by one, if it does, voila! We don't need it anyway. |
|
I have checked it and it works without that parameter. On Friday, August 5, 2016, Siddharth Kannan notifications@github.com
Nishant Nikhil |
|
Thanks @nishnik ! I will remove that parameter. |
FIXES #2 Shortlog: Siddharth Kannan (12): Add settings.py for dotenv setup Add python-dotenv to the requirements list Try some other things, still can't make it work! Change the IIT ERP2 Urls to appropriate values Show the secret question returned from ERP Fix typo in requirements file Change all the URLs to HTTPS Try different requests (from the Dev Console) Change the requested URL! Works! remove redundant loc, fix encoding Clean up, remove unnecessary lines, change print locations Remove unnecessary parameter from header url
I have deployed this on my Personal Heroku account, and it works fine. If any of you wants to try the deploy out from scratch, that would be great.
I will let this PR be here for a few hours before merging it. Tell me what you think 😄
cc @amrav @hargup @nishnik