8000 1040 Add network retries to CW requests by leite08 · Pull Request #3657 · metriport/metriport · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1040 Add network retries to CW requests #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

1040 Add network retries to CW requests #3657

wants to merge 1 commit into from

Conversation

leite08
Copy link
Member
@leite08 leite08 commented Apr 10, 2025

Ref. metriport/metriport-internal#1040

Dependencies

none

Description

Add network retries to most requests to CW.

Context is that we constantly have networking errors from CW. This makes the integration more reliable and results in less work for us on the ops side.

Testing

...WIP

  • Local
    • [ ]
  • Staging
    • testing step 1
    • testing step 2
  • Sandbox
    • testing step 1
    • testing step 2
  • Production
    • testing step 1
    • testing step 2

[Release PRs:]

Check each PR.

Release Plan

[How does the changes on this PR impact/interact with the existing environment (database, configs, secrets, FFs, api contracts, etc.)?
Consider creating 2+ PRs if we need to ship those changes in a staged way]

[This is the release plan for production]

[You should execute the exact same steps when releasing to staging to validate it works]

[Add and remove items below accordingly]

  • ⚠️ Points to master
  • ⚠️ This contains a DB migration
  • Maintenance window scheduled/created at Checkly (if needed)
  • Execute this on ,
    • step1
    • step2
  • Added to monthly product update (deprecates a feature that needs to be communicated with customers)
  • Added to monthly product update (introduce a feature that would be useful customers)
  • Upstream dependencies are met/released
  • Release NPM packages
  • Fern Definition Updated
  • Release Fern SDKs
  • FFs have been set in Staging, Production, and Sandbox
  • No dependencies between API and Infra that will cause errors during deployment
  • [action n-1]
  • [action n]
  • Merge this

@leite08
refactor: add network retries to most requests to CW
f991b2d 
Ref. metriport/metriport-internal#1040

Signed-off-by: Rafael Leite <2132564+leite08@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Apr 10, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leite08 leite08 changed the title 1040 Add network retries to most requests to CW 1040 Add network retries to CW requests Apr 11, 2025
@leite08 leite08 mentioned this pull request Apr 11, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo will be requested when the pull request is marked ready for review Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 will be requested when the pull request is marked ready for review Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov will be requested when the pull request is marked ready for review RamilGaripov is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes will be requested when the pull request is marked ready for review thomasyopes is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella will be requested when the pull request is marked ready for review lucasdellabella is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leite08
0