fix(repo): unify aws-cdk dep across repo #3798
Conversation
metriport/metriport-internal#1040 Ref: ENG-263 Signed-off-by: Lucas Della Bella <dellabella.lucas@gmail.com>
WalkthroughThe changes update the AWS CDK version from 2.122.0 to 2.133.0 in all relevant GitHub Actions workflow files and add the corresponding "aws-cdk" package as a development dependency in Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions Workflow
participant AWS CDK
participant AWS Cloud
GitHub Actions Workflow->>AWS CDK: Install CDK v2.133.0
GitHub Actions Workflow->>AWS CDK: Run cdk diff/deploy steps
AWS CDK->>AWS Cloud: Deploy/Update Cloud resources
AWS Cloud-->>AWS CDK: Deployment status
AWS CDK-->>GitHub Actions Workflow: Report results
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
70-71: Review dependency ordering change
The swap of"semver"and"sharp"ordering independenciesseems incidental. Consider using a consistent ordering strategy (e.g., alphabetical) to reduce churn and improve readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
.github/workflows/_deploy-cdk.yml(8 hunks).github/workflows/_deploy-hl7-notification-cdk.yml(4 hunks).github/workflows/_deploy-hl7-vpn-tunnel-cdk.yml(1 hunks)package.json(3 hunks)
🔇 Additional comments (14)
package.json (1)
80-81: Add aws-cdk to devDependencies
Adding"aws-cdk": "~2.133.0"here aligns your monorepo CLI version with the workflows. Please verify that your lock file (package-lock.jsonoryarn.lock) is updated to reflect this new devDependency..github/workflows/_deploy-hl7-vpn-tunnel-cdk.yml (1)
105-106: Bump CDK version for VPN Tunnel Stack
Updated thecdk_versioninput to"2.133.0"to match the standardized AWS CDK version across the repo..github/workflows/_deploy-cdk.yml (8)
202-203: Bump CDK version for Secrets diff
Thecdk_versioninput for the Secrets stack diff step is updated to"2.133.0".
214-215: Bump CDK version for Secrets deploy
Thecdk_versioninput for the Secrets stack deploy step is updated to"2.133.0".
230-231: Bump CDK version for Location Services diff
Thecdk_versioninput for the Location Services stack diff step is updated to"2.133.0".
244-245: Bump CDK version for Location Services deploy
Thecdk_versioninput for the Location Services stack deploy step is updated to"2.133.0".
259-260: Bump CDK version for API diff
Thecdk_versioninput for the API stack diff step is updated to"2.133.0".
271-272: Bump CDK version for API deploy
Thecdk_versioninput for the API stack deploy step is updated to"2.133.0".
287-288: Bump CDK version for IHE diff
Thecdk_versioninput for the IHE stack diff step is updated to"2.133.0".
300-301: Bump CDK version for IHE deploy
Thecdk_versioninput for the IHE stack deploy step is updated to"2.133.0"..github/workflows/_deploy-hl7-notification-cdk.yml (4)
132-133: Bump CDK version for Secrets diff
Thecdk_versioninput for the Secrets stack diff step is updated to"2.133.0".
144-145: Bump CDK version for Secrets deploy
Thecdk_versioninput for the Secrets stack deploy step is updated to"2.133.0".
159-160: Bump CDK version for HL7 Notification diff
Thecdk_versioninput for the HL7 Notification Routing stack diff step is updated to"2.133.0".
172-173: Bump CDK version for HL7 Notification deploy
Thecdk_versioninput for the HL7 Notification Routing stack deploy step is updated to"2.133.0".
| @@ -77,6 +77,7 @@ | |||
| "@tsconfig/recommended": "^1.0.2", | |||
| "@typescript-eslint/eslint-plugin": "^5.48.2", | |||
| &q 8000 uot;@typescript-eslint/parser": "^5.48.2", | |||
| "aws-cdk": "~2.133.0", | |||
There was a problem hiding this comment.
since this can be executed outside of our npm scripts, I suggest doing a global install, like we have on preinstall - link
There was a problem hiding this comment.
@leite08 but instead of doing a global install we can just have people run this via npx cdk ... which imo is better, esp since it ties the version of cdk to the standard npm install flow.
There was a problem hiding this comment.
Great point, let's keep like this and move the ones on preinstall here, update the README/onboarding and notify the team?
There was a problem hiding this comment.
I think the ones in preinstall need to stay there because is-ci is used in prepare-dev which runs on preinstall, before dependencies get installed. And rimraf is used to nuke node_modules which would include nuking itself if it wasn't installed globally.
At least thats what it looks like to me
metriport/metriport-internal#1040
Ref: ENG-263
Signed-off-by: Lucas Della Bella dellabella.lucas@gmail.com
Dependencies
None
Description
packages/infra/package.json uses "~2.133.0" as its dependency.
Let's install aws-cdk at the mono repo level to create a clear default version for cli use. This also means we really should be using a consistent version in our gh actions workflows.
Testing
None
Release Plan
Summary by CodeRabbit