8000 build: add valid html attribute by Orta21 · Pull Request #3868 · metriport/metriport · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build: add valid html attribute #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

build: add valid html attribute #3868

merged 1 commit into from
May 26, 2025
+3 −3

Conversation

Orta21
Copy link
Member
@Orta21 Orta21 commented May 19, 2025 •
edited
Loading

Part of eng-322

Issues:

Dependencies

  • Upstream: none
  • Downstream: none

Description

  • Make sure the html element has a valid attribute

Testing

  • Local
    • attribute is valid
  • Staging
    • attribute is valid
  • Production
    • attribute is valid

Check each PR.

Release Plan

  • Merge this

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a syntax error in the HTML output for medication tables to ensure the data-id attribute on table rows is properly formatted and displays medication statement IDs as intended.

@Orta21
build: add valid html attribute
8000
7010248 
Part of eng-322

Signed-off-by: Jorge Orta <36802074+Orta21@users.noreply.github.com>
@linear Linear
Copy link
linear bot commented May 19, 2025

ENG-322 Fix missing equals sign in data-id attribute in HTML output

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 19, 2025 •
edited
Loading

Walkthrough

A syntax error in the HTML template string for the data-id attribute within the createSectionInMedications function was corrected across three files. The missing equals sign in the <tr data-id> attribute was fixed to ensure valid HTML output. No other logic or exported declarations were changed.

Changes

Files Change Summary
packages/core/src/external/aws/lambda-logic/bundle-to-html-adhd.ts
packages/core/src/external/aws/lambda-logic/bundle-to-html-derm.ts
packages/core/src/external/aws/lambda-logic/bundle-to-html.ts		 Fixed a syntax error in the HTML template string: added a missing equals sign in the data-id attribute of the <tr> tag within the createSectionInMedications function.

Sequence Diagram(s)

No sequence diagram generated as the changes are limited to template string syntax correction and do not affect control flow or feature logic.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/punycode/-/punycode-2.3.1.tgz failed, reason: C0CC46DDB17F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-19T16_02_07_306Z-debug-0.log

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2dfc120 and 7010248.

📒 Files selected for processing (3)
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-adhd.ts (1 hunks)
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-derm.ts (1 hunks)
  • packages/core/src/external/aws/lambda-logic/bundle-to-html.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.ts`: - Use the Onion Pattern to organize a package's code in layers - Try to use immutable code and avoid sharing state across different functions, objects, and systems - Try...

**/*.ts: - Use the Onion Pattern to organize a package's code in layers

  • Try to use immutable code and avoid sharing state across different functions, objects, and systems
  • Try to build code that's idempotent whenever possible
  • Prefer functional programming style functions: small, deterministic, 1 input, 1 output
  • Minimize coupling / dependencies
  • Avoid modifying objects received as parameter
  • Only add comments to code to explain why something was done, not how it works
  • Naming
    • classes, enums: PascalCase
    • constants, variables, functions: camelCase
    • file names: kebab-case
    • table and column names: snake_case
    • Use meaningful names, so whoever is reading the code understands what it means
    • Don’t use negative names, like notEnabled, prefer isDisabled
    • For numeric values, if the type doesn’t convey the unit, add the unit to the name
  • Typescript
    • Use types
    • Prefer const instead of let
    • Avoid any and casting from any to other types
    • Type predicates: only applicable to narrow down the type, not to force a complete type conversion
    • Prefer deconstructing parameters for functions instead of multiple parameters that might be of
      the same type
    • Don’t use null inside the app, only on code interacting with external interfaces/services,
      like DB and HTTP; convert to undefined before sending inwards into the code
    • Use async/await instead of .then()
    • Use the strict equality operator ===, don’t use abstract equality operator ==
    • When calling a Promise-returning function asynchronously (i.e., not awaiting), use .catch() to
      handle errors (see processAsyncError and emptyFunction depending on the case)
    • Date and Time
      • Always use buildDayjs() to create dayjs instances
      • Prefer dayjs.duration(...) to create duration consts and keep them as duration
  • Prefer Nullish Coalesce (??) than the OR operator (||) to provide a default value
  • Avoid creating arrow functions
  • Use truthy syntax instead of in - i.e., if (data.link) not if ('link' in data)
  • Error handling
    • Pass the original error as the new one’s cause so the stack trace is persisted
    • Error messages should have a static message - add dynamic data to MetriportError's additionalInfo prop
    • Avoid sending multiple events to Sentry for a single error
  • Global constants and variables
    • Move literals to constants declared after imports when possible (avoid magic numbers)
    • Avoid shared, global objects
  • Avoid using console.log and console.error in packages other than utils, infra and shared,
    and try to use out().log instead
  • Avoid multi-line logs
    • don't send objects as a second parameter to console.log() or out().log()
    • don't create multi-line strings when using JSON.stringify()
  • Use eslint to enforce code style
  • Use prettier to format code
  • max column length is 100 chars
  • multi-line comments use /** */
  • scripts: top-level comments go after the import
  • packages/core/src/external/aws/lambda-logic/bundle-to-html.ts
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-adhd.ts
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-derm.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: check-pr / lint-build-test
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/core/src/external/aws/lambda-logic/bundle-to-html-derm.ts (1)

1322-1322: Fixed HTML syntax error for data-id attribute

Added the missing equals sign in the HTML attribute syntax, changing from data-id"${...}" to data-id="${...}". This ensures valid HTML is generated.

packages/core/src/external/aws/lambda-logic/bundle-to-html.ts (1)

1014-1014: Fixed HTML syntax error for data-id attribute

Added the missing equals sign in the HTML attribute syntax, changing from data-id"${...}" to data-id="${...}". This ensures valid HTML is generated.

packages/core/src/external/aws/lambda-logic/bundle-to-html-adhd.ts (1)

1243-1243:

✅ Verification successful

Fix missing equals in data-id attribute
The HTML template now correctly includes the = in data-id="${medicationStatement.id}", ensuring valid markup.

🏁 Script executed:

#!/bin/bash
# Verify no other instances of data-id missing '=' in AWS HTML bundles
rg '<tr data-id"' -n packages/core/src/external/aws/lambda-logic

Length of output: 66

🏁 Script executed:

#!/bin/bash
# List all <tr> elements that include a data-id attribute to verify correct `=` usage
rg '<tr[^>]*data-id' -n packages/core/src/external/aws/lambda-logic

Length of output: 1127

All data-id attributes include the = and markup is valid
Verified across AWS HTML bundle templates—no instances of a missing equals sign.

Instances checked:

  • packages/core/src/external/aws/lambda-logic/bundle-to-html.ts:1014, 1308
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-derm.ts:1322, 1485, 1606
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-adhd.ts:1243, 1403, 1525
  • packages/core/src/external/aws/lambda-logic/bundle-to-html-bmi.ts:1386
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Orta21 Orta21 added this pull request to the merge queue May 26, 2025
Merged via the queue into develop with commit 88dea84 May 26, 2025
15 checks passed
@Orta21 Orta21 deleted the eng-322-invalid-html-attribute branch May 26, 2025 15:05
@Orta21 Orta21 mentioned this pull request May 26, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Orta21 @leite08
0