Tags: mgohashi/pipeline
Tags
Fix default-timeout from config not correctly set 😓 Make sure we always read from the config-default map to set the timeout on PipelineRun and TaskRun. Remove the pre 0.5.0 behavior, it has been 6 release since then. Signed-off-by: Vincent Demeester <vdemeest@redhat.com> (cherry picked from commit 44ccf4d)
Invalid Sink URI CloudEvent test sometimes includes quotes In the logs for the latest pipeline nightly we saw a failed unit test for CloudEvents with the following message: ``` TestSendCloudEvent/send_a_cloud_event_with_invalid_sink_URI: cloudevent_test.go:106: I expected an error like invalid_URI: unsupported protocol scheme, but I got Post "invalid_URI": unsupported protocol scheme "" ``` It appears that sometimes the "invalid_URI" part of the error message will include quotes, and sometimes (like when running locally) it won't. This PR updates the regex to allow for these quotes in the error message.
Spelling fixes in our doc Found using `mdspell -a -n --en-us "**/*.md"`. At some point we might want to have a built in ignore dictionary to avoid false positives. (cherry picked from commit 7b87070)
Resolved result ref order can affect unit test outcome Test TestTaskParamResolver_ResolveResultRefs performs a diff on a slice of resolved result references. Unfortunately the ordering of this slice is not guaranteed so sometimes the test fails. This PR updates the unit test to check each entry appears as expected in the tt.want slice (confirming also that the lengths of the slices match). Also adds a small helper func to format the resolved result refs for printing in the event that they don't match.
PreviousNext