8000 Add an inside observer and a property as an updates indicator by lancedikson · Pull Request #221 · mharris717/ember-cli-pagination · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add an inside observer and a property as an updates indicator #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2017

Conversation

lancedikson
Copy link
Contributor

Seems like some people run into the same question: #216 and #88. I've found a good and flexible solution to define observer inside of Route or Controller. But here is a proposal for a default one way to track updates. I'm not sure that it's the best way to do it, so let's discuss if something isn't perfect :)

Add updates counter and update events triggers to make it possible to track any changes outside using .on or observer by .contentUpdated property
@broerse
Copy link
Collaborator
broerse commented May 15, 2017

@lancedikson @mharris717 what do you think?

@lancedikson
Copy link
Contributor Author

@mharris717, one more ping :)

@broerse
Copy link
Collaborator
broerse commented May 19, 2017

@chrisccerami I think I can merge this but can you take a look?

@broerse broerse merged commit 7edd744 into mharris717:master May 26, 2017
@broerse
Copy link
Collaborator
broerse commented May 26, 2017

@lancedikson Just published 3.0.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0