feat!: move all env. vars to action inputs & follow naming conventions #6
Conversation
This change is primarily for `GITHUB_TOKEN` which is not an ENV, but part of the `secrets` context. The GH token is also available to Actions via the `github` context object which is the standard way to set a default (_the official GH action `actions/checkout` does this_).
- v2 bump - Revise inline doc comments - Remove echo step
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
No longer needed.
Applied your feedback, thanks for reviewing :)
Sure, I'll take care of that shortly 👍 |
|
due to that we can circumvent that by changing that |
I'm not familiar with the REST API or testing actions locally. I guess you're just running the JS itself without the action? If you did want to locally test the action, there is
If that's what you prefer, sure 👍 |
Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
|
as the only issue so far is due to that I tested this locally with that |
|
@micalevisk Cheers! Do you have an ETA on the v2 release? Will it be available some time next week, or is there anything else you'd like for v2? |
|
@polarathene I'll test it again & release it today |
This change is primarily for
GITHUB_TOKENwhich is not an ENV, but part of thesecretscontext.The GH token is also available to Actions via the
githubcontext object which is the standard way to set a default (the official GH actionactions/checkoutdoes this).This change was motivated by #5 (comment)
As this requires a major version bump, it may also be a good time to address the naming convention for
outputs?has_found,issue_number,is_closed=>has-found,issue-number,is-closedis more appropriate? (again referencing the official GH actions likeactions/checkout, they use kebab-case, not snake_case)