8000 [minizip-ng] disable find_package for zlib-ng by sgoth · Pull Request #45765 · microsoft/vcpkg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[minizip-ng] disable find_package for zlib-ng #45765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

[minizip-ng] disable find_package for zlib-ng #45765

merged 2 commits into from
Jun 4, 2025

Conversation

sgoth
Copy link
Contributor
@sgoth sgoth commented May 30, 2025 •
edited by LilyWangLL
Loading

Fixes #45706

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

8000
sgoth added 2 commits May 30, 2025 10:46
@sgoth
[minizip-ng] don't link to system zlib-ng
0553686 
minizip-ng 4.0.10 always prefers zlib-ng over zlib but we only provide
zlib. This leads to silently linking to zlib-ng on systems that have it
installed globally when vcpkg provided zlib is expected.
@sgoth
update version database
998a0af
@LilyWangLL LilyWangLL self-assigned this May 30, 2025
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 30, 2025
LilyWangLL
LilyWangLL suggested changes May 30, 2025
View reviewed changes
@sgoth sgoth requested a review from LilyWangLL May 30, 2025 10:58
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 4, 2025
@vicroms vicroms merged commit 737c3c9 into microsoft:master Jun 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[minizip-ng] links system zlib-ng instead of vcpkg zlib
3 participants
@sgoth @LilyWangLL @vicroms
0