10000 Fix weird grouping bug by ejizba · Pull Request #1116 · microsoft/vscode-docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix weird grouping bug #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fix weird grouping bug #1116

merged 1 commit into from
Jul 9, 2019

Conversation

ejizba
Copy link
Contributor
@ejizba ejizba commented Jul 9, 2019

Take this tree item as an example:
Screen Shot 2019-07-09 at 10 18 50 AM

An image's id is currently fullTag + id. A group's id is the same as the label. This results in the following full ids for the above screenshot:

  • /erijiz2/helloacrtasks
    • /erijiz2/helloacrtasks:v1sha256:3700e2efe77f976cb8cc80b3ae3315baaaab4e9068857da491c1e99aaf555059

However, if you change the grouping to "None" that confuses VS Code resulting in a broken view because the id for the image is still the same (just without a parent). Here are the new full ids:

  • /erijiz2/helloacrtasks|LocalGroup
    • /erijiz2/helloacrtasks|LocalGroup/erijiz2/helloacrtasks:v1sha256:3700e2efe77f976cb8cc80b3ae3315baaaab4e9068857da491c1e99aaf555059

@ejizba ejizba requested a review from a team as a code owner July 9, 2019 17:24
@ejizba ejizba merged commit b80a19e into master Jul 9, 2019
@ejizba ejizba deleted the ej/group branch July 9, 2019 20:53
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0