8000 Force custom editors wrapper element in diff view to have 100% height by mjbvz · Pull Request #96969 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Force custom editors wrapper element in diff view to have 100% height #96969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

Force custom editors wrapper element in diff view to have 100% height #96969

merged 1 commit into from
May 5, 2020

Conversation

mjbvz
Copy link
Collaborator
@mjbvz mjbvz commented May 5, 2020 •
edited
Loading

Fix for #96968

This is a scoped fix for #96968.

The cause of the issue is the following:

  1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM.
  2. In split views, we try to lay the webview out over an element that has 0 height.
  3. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show

This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but to play it safe I've scoped my fix to just webviews with this change

@mjbvz mjbvz self-assigned this May 5, 2020
@mjbvz mjbvz added this to the April 2020 milestone May 5, 2020
@mjbvz
Force custom editors in diff view to have 100% height wrappers
3778525 
Fix for microsoft#96968

This is a scoped fix for microsoft#96968.

The cause of the issue is the following:

1. Webview must be rendered outside of the main editor DOM. We do this by absolutely positioning them over some element in the DOM.
1. In split views, we try to lay the webview out over an element that has 0 height.
1. Due to my workaround in ea07e9b, this causes the webview to either not show at all (because it also will have zero height) or partially show

This fix forces the webivew's parent in the split view to have 100%. That actually seems like a reasonable default but I've scoped my fix to just webviews
@mjbvz mjbvz force-pushed the fix-webview-diff-145 branch from 57c4158 to 3778525 Compare May 5, 2020 07:37
@mjbvz mjbvz merged commit d69a79b into microsoft:release/1.45 May 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbatten sbatten sbatten approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @sbatten
0