8000 remove web extension kind by sandy081 · Pull Request #132041 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove web extension kind #132041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2021
Merged

remove web extension kind #132041

merged 2 commits into from
Sep 1, 2021

Conversation

sandy081
Copy link
Member
@sandy081 sandy081 commented Sep 1, 2021 •
edited
Loading

This PR fixes #132034

  • Filter out web extension kind when reading from extension package.json
  • Remove it from extensionKind schema in package.json and settings
  • add some tests

@sandy081 sandy081 added this to the August 2021 milestone Sep 1, 2021
@sandy081 sandy081 requested a review from alexdima September 1, 2021 10:01
@sandy081 sandy081 self-assigned this Sep 1, 2021
@sandy081 sandy081 merged commit e7d7e9a into release/1.60 Sep 1, 2021
@sandy081 sandy081 deleted the sandy081/fix132034 branch September 1, 2021 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
August 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@sandy081 @alexdima
0