8000 Allows Arrays in Setting for Code Actions on Save by justschen · Pull Request #194870 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allows Arrays in Setting for Code Actions on Save #194870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 9, 2023
Merged

Allows Arrays in Setting for Code Actions on Save #194870

merged 14 commits into from
Oct 9, 2023

Conversation

justschen
Copy link
Collaborator
@justschen justschen commented Oct 5, 2023 •
edited
Loading

regarding #194861

candidate: #194930

@justschen justschen requested a review from mjbvz October 5, 2023 18:46
@justschen justschen marked this pull request as ready for review October 5, 2023 18:51
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 5, 2023
mjbvz
mjbvz previously approved these changes Oct 5, 2023
View reviewed changes
@justschen justschen mentioned this pull request Oct 5, 2023
Merged
@gjsjohnmurray
Copy link
Contributor

I think this should be a candidate for the first recovery release.

@justschen
Copy link
Collaborator Author

candidate PR was created: #194930

@justschen justschen added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release labels Oct 5, 2023
mjbvz
mjbvz reviewed Oct 5, 2023
View reviewed changes
@justschen justschen enabled auto-merge (squash) October 5, 2023 23:59
@justschen justschen mentioned this pull request Oct 6, 2023
Closed
@justschen justschen disabled auto-merge October 6, 2023 07:16
@justschen
Copy link
Collaborator Author

added a couple commits while going back and forth on implementation, but settled for this setting[x] !== 'never' - a simple bit of code that adds checks to filter out anything that is false and "never" type at the very beginning.

This covers #194978 this issue since in the 1.83 release, all objects were found to be valid (since they were converted to strings first), and multiple source actions of the same subset would be overwritten. This behavior mimics the same as 1.82.0 but adds an additional exclusion to never, as well as the initial false value.

@justschen justschen mentioned this pull request Oct 6, 2023
Closed
@justschen justschen merged commit c146d5e into microsoft:main Oct 9, 2023
@dockleryxk dockleryxk mentioned this pull request Oct 10, 2023
Closed
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@justschen @Alex0007
Allows Arrays in Setting for Code Actions on Save (microsoft#194870)
04e6afd 
* allow arrays in settings

* cleanup

* added specification for array and object

* added additional properties for intellisense

* added better logic

* fixes issue with overwritten code actions (when multiple of same subset)

* code cleanup

* last bit of code cleanup

1 am brain go brrrrr

* reverting last couple changes. adding 1 bit of code that fixes everything

* code cleanup

late night coding >>>>

* resolving merge conflicts

merge conflicts from main?

* resolving merge conflicts part 2
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
@justschen justschen deleted the justin/save-arrays branch August 8, 2024 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz left review comments

@rebornix rebornix rebornix approved these changes

Assignees

@justschen justschen

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.
5 participants
@justschen @gjsjohnmurray @rebornix @mjbvz @vscodenpa
0