Revert: Allow non-AI actions on empty lines #200097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aeschli |
|
The changes are good. In #200098, I added a commit that removes the unused parameters as well. |
aiday-mar
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding/discovered by #199548, small change from: #198840
Contributed code actions (and any other code actions in general) were not being shown on empty lines or empty files because only AI fixes would be shown. In empty lines, VS Code typically does not contribute any code actions, but extensions and linters do, and those will not show up when we check for
isAIDoes not affect whether lightbulbs are shown or not on empty lines from the setting.
Regarding safety - not 100% on this, will defer to @aiday-mar. However, it is just reverting back to the original filtering.
cc. @aiday-mar