Fix Webview scroll position Preserving #21531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Bug** Some regression since 1.9 caused the scroll preserve behavior of webviews to stop working in certain cases. There appears to be a race condition where `newFrame.contentDocument.body` does not exist when the scroll update code is called **Fix** Instead of using a timeout, update the scroll position when `DOMContentLoaded` is fired from the webview window Fixes microsoft#21491
|
I'm still testing to make sure all cases are handled. If everything looks good, I'll take this change into master. @alexandrudima and @kieferrm, any thoughts on also cherry picking this into 1.10? |
mjbvz
added a commit
that referenced
this pull request
Mar 1, 2017
**Bug** Some regression since 1.9 caused the scroll preserve behavior of webviews to stop working in certain cases. There appears to be a race condition where `newFrame.contentDocument.body` does not exist when the scroll update code is called **Fix** Instead of using a timeout, update the scroll position when `DOMContentLoaded` is fired from the webview window Fixes #21491
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
A regression since 1.9 caused the scroll preserve behavior of webviews to stop working in certain cases. There appears to be a race condition where
newFrame.contentDocument.bodydoes not exist when the scroll preserve code is calledFix
Instead of using a timeout, update the scroll position when
DOMContentLoadedis fired from the webview windowFixes #21491