Add extra type check in findFiles2
#235692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft/vscode-copilot-release#2493 Looking at the code I'm still not sure how this can happen but it seems like we end up trying to call `.map` on a value that is not an array. Adding a more explicit exception here to hopefully track this down
justschen
previously approved these changes
Dec 10, 2024
|
@mjbvz looks like some unit tests failed (same test in linux and windows) |
ulugbekna
approved these changes
Dec 10, 2024
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Dec 16, 2024
For microsoft/vscode-copilot-release#2493 Looking at the code I'm still not sure how this can happen but it seems like we end up trying to call `.map` on a value that is not an array. Adding a more explicit exception here to hopefully track this down
mjbvz
added a commit
that referenced
this pull request
Dec 17, 2024
Add extra type check in `findFiles2` (#235692)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-copilot-release#2493
Looking at the code I'm still not sure how this can happen but it seems like we end up trying to call
.mapon a value that is not an array. Adding a more explicit exception here to hopefully track this down