8000 chore: bump node-gyp on windows to 11.2.0 by tmm1 · Pull Request #250554 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: bump node-gyp on windows to 11.2.0 #250554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: bump node-gyp on windows to 11.2.0 #250554

wants to merge 1 commit into from
+237 −285

Conversation

tmm1
8000 Copy link
Contributor
@tmm1 tmm1 commented Jun 3, 2025 •
edited
Loading

improves reliability of builds on windows

includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112

cc @deepak1556 @joaomoreno

@tmm1
chore: bump node-gyp on windows to 11.2.0
1f58070 
improves reliability of builds on windows

includes nodejs/node-gyp#3113 and nodejs/node-gyp#3112
@deepak1556 deepak1556 added this to the June 2025 milestone Jun 4, 2025
@deepak1556
Copy link
Collaborator

Thanks for the fixes in upstream! Couple of notes,

  1. This only affects the node-gyp used to fetch headers on windows

    vscode/build/npm/preinstall.js

    Line 33 in e3e5504

    installHeaders();
    , we should either have node-gyp version locked in a couple of places like remote/package.json, build/package.json, package.json to have the concurrent compilation error addressed or we could also configure npm_config_node_gyp in postinstall.js to have it take affect for all directories except root (this still needs to lock the version in package.json)
  2. The repo does not accept package-lock changes from external contributors, I will amend the lockfile changes so the PR checks can pass.

@tmm1
Copy link
Contributor Author
tmm1 commented Jun 6, 2025
  1. This only affects the node-gyp used to fetch headers on windows

Ah good catch

  1. we should either have node-gyp version locked in a couple of places like remote/package.json, build/package.json, package.json

Seems like pinning is not enough, because npm will only use 7697 its own bundled version

https://github.com/nodejs/node-gyp/blob/main/docs/Updating-npm-bundled-node-gyp.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@tmm1 @deepak1556
0