Extension tips #3034
Closed
Extension tips #3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 15, 2016 14:53
We were showing "1 characters". This fix will remove the "s" when count is singluar.
|
@waderyan it looks like this PR also includes changes to the Feedback widget. Is this an oversight? The changes to the extension tips looks good to me. |
|
Yep that was an oversight. Let me fix that. |
|
Close in favor of new PR |
|
@waderyan no need for a new PR. I can just commit the changes to the extensiontips. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple more extensions to the tips json.