Adding optout option for telemetry #3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
alexdima
added a commit
that referenced
this pull request
Feb 19, 2016
Adding optout option for telemetry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will add a user setting that will allow to optout of reporting telemetry. The product will allow a set of predefined events to pass the user optin settings. This way we can calculate the optin rates.
The change include:
ITelemetryConfigurationfrommainTelemetryServicetotelemetry.tsElectronTelemetryService. This service will be responsible for caching the events that are reported until the user optin settings are loaded. After that, the service will flush the events. This is to prevent race conditions as some events are reported on load (auto save, workspace stats, workspace load).mainTelemetryService.