8000 Fix code folding keyboard mix up by tht13 · Pull Request #3108 · microsoft/vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix code folding keyboard mix up #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix code folding keyboard mix up #3108

wants to merge 3 commits into from

Conversation

tht13
Copy link
Contributor
@tht13 tht13 commented Feb 18, 2016

The current implementation for keyboard bindings to code folding works as advertised (in the default keyboard bindings file) for single fold/unfold, but foldAll/unfoldAll is flipped.
This pull request fixes that.

Note: it is possible that the keyboard bindings are back to front i.e open/close square bracket. I have not changed them and do not know which you intended to do what. Feedback in the comments on this would be appreciated.

@msftclas
Copy link

Hi @tht13, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@tht13 tht13 changed the title Fix code colding keyboard mix up Fix code folding keyboard mix up Feb 18, 2016
@tht13
Copy link
Contributor Author
tht13 commented Feb 18, 2016

#3070 contains some of the same changes but not all

@egamma egamma added this to the Feb 2016 milestone Feb 18, 2016
@tht13 tht13 mentioned this pull request Feb 22, 2016
Closed
@aeschli aeschli closed this in fdd9624 Feb 22, 2016
@aeschli
Copy link
Contributor
aeschli commented Feb 22, 2016

@tht13 Thanks for the PR. I fixed the issue.

@tht13
Copy link
Contributor Author
tht13 commented Feb 22, 2016

You missed this line https://github.com/Microsoft/vscode/blob/fdd96243b3768909bab79da605c8982145efe2c6/src/vs/editor/contrib/folding/browser/folding.ts#L448 and line #L440 above it where the ID's are switched. I am not sure if they have any afect on the code but thought I would point it out 😄

@tht13
Copy link
Contributor Author
tht13 commented Feb 22, 2016

never mind I see you fixed it in 41640b8 👍

@tht13 tht13 deleted the code-folding branch February 22, 2016 13:04
@aeschli
Copy link
Contributor
aeschli commented Feb 22, 2016

Thanks @tht13 for having an eye on it. Right, I first forgot it.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
Feb 2016
Development

Successfully merging this pull request may close these issues.
4 participants
@tht13 @msftclas @aeschli @egamma
0