8000 For full CLR TargetFrameworks make DebugType is 'Full' (#528) by codito · Pull Request #531 · microsoft/vstest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

For full CLR TargetFrameworks make DebugType is 'Full' (#528) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2017
Merged

For full CLR TargetFrameworks make DebugType is 'Full' (#528) #531

merged 1 commit into from
Feb 22, 2017

Conversation

codito
Copy link
Contributor
@codito codito commented Feb 22, 2017

  • For full CLR TargetFrameworks make DebugType is 'Full'

  • Use TargetFrameworkIdentifier instead TargetFramework.

@smadala
For full CLR TargetFrameworks make DebugType is 'Full' (microsoft#528)
ecb72ba 
* For full CLR TargetFrameworks make DebugType is 'Full'

* Use TargetFrameworkIdentifier instead TargetFramework.
@msftclas
8000 Copy link

Hi @codito, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@harshjain2 harshjain2 self-requested a review February 22, 2017 06:03
harshjain2
harshjain2 approved these changes Feb 22, 2017
View reviewed changes
src/Microsoft.NET.Test.Sdk.targets
This can be removed once TPv2 is default for full CLR. Related issue https://github.com/Microsoft/vstest/issues/373.
-->
<PropertyGroup>
<DebugType Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">Full</DebugType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From compatibility perspective between v1 and v2, is it a good idea to keep this forever?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good idea, as @smadala mentioned in comments we should remove it once we've TPv2 OM on test explorer as well :)

@codito codito merged commit 5c460bd into microsoft:15.0-rtm Feb 22, 2017
@codito codito deleted the port-net46-pdb-fix branch February 22, 2017 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smadala smadala smadala approved these changes

@harshjain2 harshjain2 harshjain2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codito @msftclas @smadala @harshjain2
0