Use assembly information version for console runner splash banner. #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will help determine the exact version of runner used in case of user reported issues.
|
@codito, |
smadala
approved these changes
Apr 25, 2017
| #else | ||
| assemblyVersion = FileVersionInfo.GetVersionInfo(assembly.Location).ProductVersion; | ||
| #endif | ||
| assemblyVersion = assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion; | ||
| string commandLineBanner = string.Format(CultureInfo.CurrentUICulture, CommandLineResources.MicrosoftCommandLineTitle, assemblyVersion); | ||
| this.Output.WriteLine(commandLineBanner, OutputLevel.Information); |
There was a problem hiding this comment.
Can add Assert statement for this in anyone of acceptance test?
…e to include default code coverage config changes. (microsoft#753)
Adding the assemblies that are not getting signed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will help determine the exact version of runner used in case of user
reported issues.