Re-duplicate tracelogging macros to make the MSVC preprocessor happy #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, also expanded the tests to actually validate that things compile... Also, |
|
For those interested, this illustrates the issue with the MSVC preprocessor: https://godbolt.org/z/js6he3h1Y |
jonwis
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSVC preprocessor apparently won't expand macro arguments that contain commas, meaning that the
_TLGWRITE_GENERIC_PARTB_FIELDSsolution that we have currently causes issues because it combines with the previous argument throughout the entire preprocessor chain. This change re-duplicates the macros that use it to avoid this issue. Note that the same issue likely still exists if_GENERIC_PARTB_FIELDS_ENABLEDcontains multiple comma-separated values, however this doesn't appear to be an issue in practice, likely because the macros don't care and the argument gets forwarded all the way until it gets read by the lexer, which will treat commas correctly.