8000 Add verify execute permissions by aholstrup1 · Pull Request #379 · microsoft/BCApps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add verify execute permissions #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 30, 2023
Merged

Add verify execute permissions #379

merged 5 commits into from
Nov 30, 2023

Conversation

aholstrup1
Copy link
Contributor
@aholstrup1 aholstrup1 commented Nov 28, 2023 •
edited by github-actions bot
Loading

Summary

This PR addresses an inconsistency between our internal validation and the validation on BCApps. On BCApps, we do not check if objects have the appropriate permissions. This PR introduces that check.

Work Item(s)

Fixes AB#492320

@aholstrup1 aholstrup1 requested a review from a team as a code owner November 28, 2023 07:52
@github-actions github-actions bot added the Build: scripts & configs Build scripts and configuration files label Nov 28, 2023
@github-actions github-actions bot added this to the Version 24.0 milestone Nov 28, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2023
View reviewed changes
mazhelez
mazhelez reviewed Nov 29, 2023
View reviewed changes
mazhelez
mazhelez previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor
@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this parsing around, but I admit we have nothing better at the moment. So, let's do it!

@aholstrup1 aholstrup1 enabled auto-merge (squash) November 30, 2023 09:26
@aholstrup1 aholstrup1 merged commit f5b8781 into main Nov 30, 2023
@aholstrup1 aholstrup1 deleted the private/aholstrup/add_verifypermissions branch November 30, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazhelez mazhelez mazhelez approved these changes

@tomasmsft tomasmsft tomasmsft approved these changes

Assignees
No one assigned
Labels
Build: scripts & configs Build scripts and configuration files
Projects
None yet
Milestone
Version 24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aholstrup1 @mazhelez @tomasmsft
0