8000 [DRAFT] Pagination for microsoft graph module by Drakonian · Pull Request #3940 · microsoft/BCApps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[DRAFT] Pagination for microsoft graph module #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DRAFT] Pagination for microsoft graph module #3940

wants to merge 2 commits into from

Conversation

Drakonian
Copy link
Contributor

Summary

Pagination for MicrosoftGraph module

I will provide more examples and tests soon

Work Item(s)

Fixes #3926

@Drakonian Drakonian requested review from a team as code owners June 23, 2025 00:23
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Jun 23, 2025
@github-actions GitHub Actions
Copy link

Issue #3926 is not valid. Please make sure you link an issue that exists, is open and is approved.

pri-kise
pri-kise suggested changes Jun 23, 2025
View reviewed changes
Copy link
Contributor
@pri-kise pri-kise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the design so far.

Following ideas for test cases:

  • Request two items (no NextLink) -> Verify that HasMorePages returns false + NextLink is empty
  • Request two items (with NextLink) -> Verify that HasMorePages returns true + NextLink contains a value.

src/System Application/App/MicrosoftGraph/src/GraphPaginationData.Codeunit.al

var
GraphPaginationDataImpl: Codeunit "Graph Pagination Data Impl.";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe be able to specify the value $skip for skip here, too?

Following scenario:
Someone wants to call the GetWithPagination but it should return only all results after the first record.

Technically I think that we don't need this, since we can specify the value for $skip in the optional parameters.

Maybe we should provide a Readme with some examples how to use those new procedures instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pri-kise pri-kise pri-kise requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
AL: System Application From Fork Pull request is coming from a fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Pagination for MicrosoftGraph module
2 participants
@Drakonian @pri-kise
0