8000 Cleanup system app code by AndreasMoth · Pull Request #397 · microsoft/BCApps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cleanup system app code #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 1, 2023
Merged

Cleanup system app code #397

merged 12 commits into from
Dec 1, 2023

Conversation

AndreasMoth
Copy link
Contributor
@AndreasMoth AndreasMoth commented Dec 1, 2023 •
edited by github-actions bot
Loading

Cleaning up system app code to be more aligned:

  • Fix casings
  • Sort permissions
  • trim whitespaces
  • remove empty sections
  • remove redundant app areas

Fixes AB#492871

IhorHandziuk
IhorHandziuk reviewed Dec 1, 2023
View reviewed changes
IhorHandziuk
IhorHandziuk previously approved these changes Dec 1, 2023
View reviewed changes
@AndreasMoth AndreasMoth marked this pull request as ready for review December 1, 2023 11:39
@AndreasMoth AndreasMoth requested review from a team as code owners December 1, 2023 11:39
JesperSchulz
JesperSchulz previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor
@JesperSchulz JesperSchulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Calms my OCD ;-)

IhorHandziuk
IhorHandziuk previously approved these changes Dec 1, 2023
View reviewed changes
darjoo
darjoo previously approved these changes Dec 1, 2023
View reviewed changes
@github-actions github-actions bot added this to the Version 24.0 milestone Dec 1, 2023
@AndreasMoth AndreasMoth enabled auto-merge (squash) December 1, 2023 12:46
@AndreasMoth AndreasMoth merged commit a73c1f8 into main Dec 1, 2023
@AndreasMoth AndreasMoth deleted the private/anmoth/CleanupSystemApp branch December 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhorHandziuk IhorHandziuk IhorHandziuk approved these changes

@darjoo darjoo darjoo approved these changes

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@qutreson qutreson qutreson approved these changes

@WaelAbuSeada WaelAbuSeada WaelAbuSeada approved these changes

Assignees
No one assigned
Labels
AL: System Application
Projects
None yet
Milestone
Version 24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreasMoth @IhorHandziuk @darjoo @JesperSchulz @qutreson @WaelAbuSeada
0