add SSM cache invalidation #190
Conversation
- support cache invalidation for the SSM middleware
- refactored the corresponding tests a bit to make it easier to run scenarios that involves multiple invocations
Refactor SSM getParametersByPath to work recursively (#183)
# Conflicts: # src/middlewares/__tests__/ssm.js # src/middlewares/ssm.js
There was a problem hiding this comment.
Great stuff @theburningmonk, thanks a million for submitting this great improvement.
I have only one comment regarding bluebird. Let me know what you think and then I'd be happy to approve this.
src/middlewares/__tests__/ssm.js
Outdated
| }) | ||
| }).then(() => { | ||
| if (delay) { | ||
| return Promise.delay(delay) |
There was a problem hiding this comment.
Are we adding bluebird only for this feature (Promise.delay)?
Can't we just do something like the following and get rid of bluebird?
// ...
return new Promise((resolve, reject) => setTimeout(resolve, delay))
// ...I know this is only for dev mode, but I would prefer to avoid to introduce new libs if they don't bring a substantial value.
|
@lmammino done, removed the dev dependency on |
|
Awesome :) I will version bump and get this merged shortly. I'll also port these changes to the work in progress 1.0.0 branch! Thanks again @theburningmonk, great to have you contributing to middy! |
|
@lmammino no probs, really appreciate the work you're doing with middy! |
|
Thanks @theburningmonk, but it's not just me, lots of fantastic people are contributing every day to this project... I can barely keep up with it! 😛 |