Bug with long pathnames #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t pull --stat` for changes with these long paths. You get a truncated path: ``` .../deeply/nested/directory/hierarchy/this.service | 6 +++--- ``` This will not match the set `dir` in the gitopper configuration. Unfortunately you cannot set the maximum width in `git pull --stat` but possible with `git diff --stat`. We have to separate the steps when checking for changes. That is, `git fetch`, `git diff`, then `git merge`. The default kernel-imposed limit in Linux is 4096 so just use that too. It does `git diff` now so we can also set `--name-only` to get a clean output for string matching. We can skip matching the path inside the `git pull --stat` output format.
|
haha, of course git does this.. thanks for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with paths longer than 80 characters. When running
git pull --statfor changes with these long paths. You get a truncated path:This will not match the set
dirin the gitopper configuration.Unfortunately you cannot set the maximum width in
git pull --statbut possible withgit diff --stat. We have to separate the steps when checking for changes. That is,git fetch,git diff, thengit merge. The default kernel-imposed limit in Linux is 4096 so just use that too.It does
git diffnow so we can also set--name-onlyto get a clean output for string matching. We can skip matching the path inside thegit pull --statoutput format.