8000 ci: added Windows and MacOS runners for the test suite by boenrobot · Pull Request #6021 · mikro-orm/mikro-orm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: added Windows and MacOS runners for the test suite #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ci: added Windows and MacOS runners for the test suite #6021

wants to merge 2 commits into from

Conversation

boenrobot
Copy link
Collaborator

No description provided.

@boenrobot
fix(core): fixed dynamic imports on Windows
666ec32 
This most notably affects the migration generator.
@boenrobot boenrobot marked this pull request as draft September 12, 2024 12:24
@codecov Codecov
Copy link
codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (bc14925) to head (5d10aea).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6021   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files         264      264           
  Lines       18735    18735           
  Branches     4655     4655           
=======================================
  Hits        18698    18698           
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boenrobot boenrobot force-pushed the crossRunnerTesting branch 6 times, most recently from e3a8dd1 to b836b4d Compare September 12, 2024 16:14
@boenrobot boenrobot mentioned this pull request Sep 12, 2024
Merged
@boenrobot boenrobot added the help wanted Extra attention is needed label Sep 13, 2024
@boenrobot
Copy link
Collaborator Author
boenrobot commented Sep 13, 2024 •
edited
Loading

While I can run Linux containers locally on Windows, I don't see how I can switch GitHub Actions' Windows runner to use Linux containers for Docker. They don't have DockerCli available apparently :/

I have submitted https://github.com/orgs/community/discussions/138554 asking for help, but it's worth acknowledging this here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boenrobot
0