8000 Add codecov.yml and configure codecov PR comments by lebrice · Pull Request #97 · mila-iqia/milatools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add codecov.yml and configure codecov PR comments #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add codecov.yml and configure codecov PR comments #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd54cc9
Add codecov.yml and configure PR comments
lebrice Feb 7, 2024
811157b
Update checkout@v4, setup-python@v5 in CI checks
lebrice Feb 7, 2024
070355c
Remove the 'base' key in patch status check
lebrice Feb 7, 2024
4cf8b0f
Intentionally include uncovered code to test CI
lebrice Feb 7, 2024
0eea9d3
Try to make the codecov PR comments work
lebrice Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.10'
- run: pip install pre-commit
Expand All @@ -33,7 +33,7 @@ jobs:
python -m pip install --upgrade pip
pip install poetry
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: poetry
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
run: poetry run pytest --cov=milatools --cov-report=xml --cov-append -s

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./coverage.xml
flags: unittests
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# NOTE: Replacing this with our customized version of
# - uses: koesterlab/setup-slurm-action@v1
Expand All @@ -120,7 +120,7 @@ jobs:
ssh -o 'StrictHostKeyChecking no' localhost id

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

Expand All @@ -137,7 +137,7 @@ jobs:
SLURM_CLUSTER: localhost

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./coverage.xml
flags: integrationtests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
pip install poetry

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: poetry
Expand Down
18 changes: 18 additions & 0 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
ignore:
- "tests/**/*"

coverage:
status:
project:
default:
target: auto
threshold: 1%
paths:
- "milatools"
patch:
default:
target: auto
threshold: 0%

github_checks:
annotations: true
4 changes: 4 additions & 0 deletions milatools/cli/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,10 @@ def mila():
return function(**args_dict)


def test_uncovered_code():
...


Comment on lines +386 to +389
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a comment mentioning that it isn't covered. We'll have to wait until the codecov app is approved by IT to get them.

def setup_logging(verbose: int) -> None:
global_loglevel = (
logging.CRITICAL
Expand Down
0