Move email templates to data #5496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a57ba81 to
69540ee
Compare
69540ee to
5106a2b
Compare
JAORMX
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current email template contents are both hard-coded and Stacklok-specific. Move these to
kodata, so that other users can customize their own email templates.I also noticed that we were using
NewSafeHTMLTemplatefor the text body, and re-parsing the templates every time -- this is now moved to module-level initialization (this means you need to restart the server to pick up new templates, but this seems reasonable given that other config requires a restartChange Type
Mark the type of change your PR introduces:
Testing
Unit tests (so far) -- will do some integration testing after merge.
Review Checklist: