10000 Update regal to 0.31.1 and OPA to 1.1.0 by evankanderson · Pull Request #5522 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update regal to 0.31.1 and OPA to 1.1.0 #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

Update regal to 0.31.1 and OPA to 1.1.0 #5522

merged 3 commits into from
Mar 21, 2025

Conversation

evankanderson
Copy link
Member

Summary

Replaces #5489, which did not have passing tests for whatever reason.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner March 19, 2025 23:37
@coveralls
Copy link
coveralls commented Mar 19, 2025 •
edited
Loading

Coverage Status

coverage: 56.561% (+0.006%) from 56.555%
when pulling 5647195 on evankanderson:bump-regal
into 1830ce4 on mindersec:main.

JAORMX
JAORMX reviewed Mar 20, 2025
View reviewed changes
docker/minder/Dockerfile
@@ -1,7 +1,7 @@
# SPDX-FileCopyrightText: Copyright 2023 The Minder Authors
# SPDX-License-Identifier: Apache-2.0

FROM index.docker.io/library/golang:1.23.4@sha256:574185e5c6b9d09873f455a7c205ea0514bfd99738c5dc7750196403a44ed4b7 AS builder
FROM index.docker.io/library/golang:1.23.6@sha256:adfbe17b774398cb090ad257afd692f2b7e0e7aaa8ef0110a48f0a775e3964f4 AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this Dockerfile at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of a test leg... I think some folks were using docker compose to kick off local Dockerfile builds (vs using ko's cross-build capability).

I'd be happy to ditch it, maybe I'll ask on the #minder OpenSSF channel.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ditch it

@evankanderson evankanderson merged commit 657d281 into mindersec:main Mar 21, 2025
36 of 37 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evankanderson @coveralls @JAORMX
0