8000 Move email file parsing (and env setting) to TestMain to reduce flakes by evankanderson · Pull Request #5523 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move email file parsing (and env setting) to TestMain to reduce flakes #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Move email file parsing (and env setting) to TestMain to reduce flakes #5523

merged 1 commit into from
Mar 20, 2025

Conversation

evankanderson
Copy link
Member

Summary

I've seen a bunch of flakes in ./internal/invites tests after I moved the templates to be read from the filesystem in an initOnce. Move the fetch and parse of these files to TestMain, which runs before the tests, to hopefully trigger the initialization before other tests are running around affecting things.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Ran go test -count 2 ./... and checked that these tests passed (there are a few other that aren't multi-count safe that I will try to fix in the future).

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner March 20, 2025 13:52
@coveralls
Copy link

Coverage Status

coverage: 56.584%. remained the same
when pulling f2622f1 on evankanderson:reduce-invite-flakiness
into 73d14c9 on mindersec:main.

@evankanderson evankanderson merged commit f3a02ee into mindersec:main Mar 20, 2025
26 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects 45CD
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evankanderson @coveralls @JAORMX
0