8000 Clean up react dependabot batching, remove old docusarus v2 holdbacks by evankanderson · Pull Request #5556 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up react dependabot batching, remove old docusarus v2 holdbacks #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Clean up react dependabot batching, remove old docusarus v2 holdbacks #5556

merged 1 commit into from
Apr 1, 2025

Conversation

evankanderson
Copy link
Member

Summary

#5542 and #5543 try to bump react-dom and react, respectively, and each fails with:

[cause]: Error: Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:
    - react:      19.1.0
    - react-dom:  19.0.0

or an equivalent dependency error. This should group them together.

I also noticed some comments about upgrades to MDX which were relevant for docusaurus v2, but shouldn't be a problems for v3.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner April 1, 2025 13:34
@coveralls
Copy link

Coverage Status

coverage: 56.762%. remained the same
when pulling 6f3f07b on dependabot-batch
into 8cb2239 on main.

@evankanderson evankanderson merged commit e6e1386 into main Apr 1, 2025
26 checks passed
@evankanderson evankanderson deleted the dependabot-batch branch April 1, 2025 14:13
@BrewTestBot BrewTestBot mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evankanderson @coveralls @JAORMX
0