8000 Fix flag protection logic on project delete by evankanderson · Pull Request #5590 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix flag protection logic on project delete #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

Fix flag protection logic on project delete #5590

merged 1 commit into from
Apr 17, 2025

Conversation

evankanderson
Copy link
Member

Summary

I added the flag projection logic after the manual testing, and I screwed up the delete logic trying to reduce nesting. (I tested create after changes, then was in a hurry to hit send.)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I'm manually testing right now. Unfortunately, we don't have automated test coverage here, and it looks thorny to add it. :sadface:

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner April 17, 2025 04:03
@coveralls
Copy link

Coverage Status

coverage: 56.894% (+0.001%) from 56.893%
when pulling c0b4903 on evankanderson:fix-project-flag
into f256d12 on mindersec:main.

JAORMX
JAORMX approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably checking for hierarchical feature flags should be a function by itself. Not for this PR though

@evankanderson
Copy link
Member Author

Probably checking for hierarchical feature flags should be a function by itself. Not for this PR though

We should probably call them entitlements as well, so there would be flags (admin controlled feature rollouts) and entitlements (customer-selected feature enablement)

@evankanderson evankanderson merged commit 67c5c11 into mindersec:main Apr 17, 2025
25 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evankanderson @coveralls @JAORMX
0