8000 Remove a bunch of references to Stacklok APIs and services which have been retired by evankanderson · Pull Request #5617 · mindersec/minder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove a bunch of references to Stacklok APIs and services which have been retired #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Remove a bunch of references to Stacklok APIs and services which have been retired #5617

merged 1 commit into from
May 5, 2025

Conversation

evankanderson
Copy link
Member

Summary

Stacklok has retired their public instance of Minder. Fortunately, Custcodian is offering a free cloud-hosted instance which we can replace the references to.

This PR also retires references to Stacklok Insight (aka Trusty), as that API has changed and no longer works with the current Minder integration.

Fixes #5616

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I did a large search for "stacklok", and investigated each occurrence. I tried to keep this as small as possible, but there were a lot of places still referencing Stacklok resources.

I'm planning to let the unit testing and CI process flag if I've screwed up the automation, but I have locally built the minder CLI and verified that it will now call api.custcodian.dev. I intend to cut a 0.0.89 release after this PR merges.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@evankanderson evankanderson requested a review from a team as a code owner May 5, 2025 03:31
@evankanderson evankanderson force-pushed the retire-stacklok-instance branch from 904cf77 to c34bcc7 Compare May 5, 2025 03:53
@coveralls
Copy link

Coverage Status

coverage: 56.915% (+0.003%) from 56.912%
when pulling c34bcc7 on evankanderson:retire-stacklok-instance
into c225e9e on mindersec:main.

@rdimitrov rdimitrov merged commit 69deec1 into mindersec:main May 5, 2025
26 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias approved these changes

@rdimitrov rdimitrov rdimitrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacklok Public Instance
4 participants
@evankanderson @coveralls @eleftherias @rdimitrov
0