Create agent: support wildcards in tables / KB names #11067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tables, ignore_knowledge_bases
|
Unable to Process PR Review The author of this PR does not exist on Entelligence Dashboard. Please add the user to Entelligence AI here to enable reviews for this user. |
# Conflicts: # mindsdb/interfaces/skills/sql_agent.py
StpMax
approved these changes
Jun 20, 2025
Comment on lines
121
to
131
| if len(table.parts) == 1: | ||
| tbl = table.parts[0] | ||
| elif len(table.parts) == 2: | ||
| db, tbl = table.parts | ||
| db = db.lower() | ||
| elif len(table.parts) == 3: | ||
| db, schema, tbl = table.parts | ||
| schema = schema.lower() | ||
| db = db.lower() | ||
| else: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
much more readable :p
match [x.lower() for x in parts]:
case [tbl]:
pass
case [db, tb
10000
l]:
pass
case [db, schema, tbl]:
pass
case _:
raise NotImplementedError- get all KB to detect what object was requested by agent - depending on it check_knowledge_base_permission or check_table_permission is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example:
CREATE AGENT my_agent_1 USING ... include_knowledge_bases= ['kb_*'], ignore_knowledge_bases= ['kb_ollama*'], include_tables=['my_pg.a*','files.ml*'], ignore_tables=['my_pg.aaa*'],Fixes https://linear.app/mindsdb/issue/RES-60/add-entire-database-to-agents
Type of change
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: