add/del cli #401
Open
add/del cli #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #183 |
|
Do we want API calls for each of the add functions? I did not because it seems to conflict with addhost, addswitch and addlink in net.py. |
|
We probably want to standardize on the delete vs. remove terminology. Regarding API calls for CLI commands, I'm not sure. Probably it's fine the way you've done it - the methods aren't particularly long. |
6c2a54a to
c7e4c81
Compare
This will make the "links" command not show deleted links
Remove references to links when deleting a link or node.
744c073 to
4f8aa1d
Compare
|
Since |
b08c9d1 to
6be4bfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at creating a cli that can add/delete objects. This will only work so far with OVS. There is much more that could be done but I think this is simple enough to use.