8000 update `minio/kms-go/kms` SDK by aead · Pull Request #21233 · minio/minio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update minio/kms-go/kms SDK #21233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

update minio/kms-go/kms SDK #21233

merged 1 commit into from
Apr 24, 2025

Conversation

aead
Copy link
Member
@aead aead commented Apr 23, 2025

Description

Update the MinKMS Go SDK

Motivation and Context

KMS

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@aead aead requested a review from klauspost April 23, 2025 13:16
shtripat
shtripat approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor
@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aead
update minio/kms-go/kms SDK
15f53e6 
Signed-off-by: Andreas Auernhammer <github@aead.dev>
@harshavardhana harshavardhana merged commit 427826a into master Apr 24, 2025
22 of 24 checks passed
@harshavardhana harshavardhana deleted the kms-go branch April 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@klauspost klauspost klauspost approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aead @harshavardhana @klauspost @shtripat
0