8000 typo: return actual error from RemoveRemoteTargetsForEndpoint by wooffie · Pull Request #21238 · minio/minio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

typo: return actual error from RemoveRemoteTargetsForEndpoint #21238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

typo: return actual error from RemoveRemoteTargetsForEndpoint #21238

merged 1 commit into from
Apr 26, 2025

Conversation

wooffie
Copy link
Contributor
@wooffie wooffie commented Apr 25, 2025

Sorry if not applicable, but maybe in this place we should return actual error?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

shtripat
shtripat approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shtripat shtripat requested a review from poornas April 25, 2025 10:50
@harshavardhana harshavardhana merged commit 93c389d into minio:master Apr 26, 2025
22 checks passed
harshavardhana pushed a commit that referenced this pull request May 30, 2025
@wooffie @harshavardhana
typo: return actual error from RemoveRemoteTargetsForEndpoint (#21238)
af71c38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@klauspost klauspost klauspost approved these changes

@shtripat shtripat shtripat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wooffie @poornas @klauspost @shtripat @harshavardhana
0