8000 feat(helm): support minAvailable and templated name in podDisruptionBudget by mydoomfr · Pull Request #21245 · minio/minio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(helm): support minAvailable and templated name in podDisruptionBudget #21245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(helm): support minAvailable and templated name in podDisruptionBudget #21245

wants to merge 1 commit into from

Conversation

mydoomfr
Copy link
8000

Description

This pull request updates the PodDisruptionBudget configuration in the MinIO Helm chart, improving flexibility by supporting both the minAvailable and maxUnavailable settings.

It also update the metadata.name field to use a templated value.
The name field could be a breaking change. If we prefer to keep the hardcoded value, I can revert the change.
However, I thought it would be better to align with the other manifests.

maxUnavailable setting was previously hardcoded with the value '1'. Now, if the value is not explicitly set, it will no longer be applied. This change should also be considered a potential breaking change.

Motivation and Context

How to test this PR?

helm template minio . --set podDisruptionBudget.enabled=true
---
# Source: minio/templates/poddisruptionbudget.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: minio
  labels:
    app: minio
spec:
  selector:
    matchLabels:
      app: minio
helm template minio . \
--set podDisruptionBudget.enabled=true \
--set podDisruptionBudget.maxUnavailable=2 \
--set podDisruptionBudget.minAvailable=1
---
# Source: minio/templates/poddisruptionbudget.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: minio
  labels:
    app: minio
spec:
  minAvailable: 1
  maxUnavailable: 2
  selector:
    matchLabels:
      app: minio

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@mydoomfr mydoomfr force-pushed the feat-pdb-minavailable branch from d0e10b1 to 7e9013a Compare May 15, 2025 08:08
@mydoomfr
feat(helm): support minAvailable in podDisruptionBudget
de36046 
Signed-off-by: Benjamin Pinchon <dev@mdfr.me>
@mydoomfr mydoomfr force-pushed the feat-pdb-minavailable branch from 7e9013a to de36046 Compare May 19, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mydoomfr
0