8000 fix file drag & drop by replacing /cygdrive with /mnt by jagd · Pull Request #8 · mintty/wsltty · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix file drag & drop by replacing /cygdrive with /mnt #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix file drag & drop by replacing /cygdrive with /mnt #8

wants to merge 1 commit into from

Conversation

jagd
Copy link
@jagd jagd commented Oct 9, 2016

Hi,

I am used to dragging and dropping files a lot. However, files on the disk should be dropped with names like /mnt/c/pagefile.sys instead of /cygdrive/c/pagefile.sys.

The most simple way is to
$ sudo ln -s /mnt /cygdrive
However, this requires a sudo and the change of the root content, whereas in my opinion, wsltty should not change the LXSS.

Another simple soluton without changing the newlib-cygwin is to replace "/cygdrive" with "/mnt", as this patch does.

Of course there is still a known issue: the installation folder of wsltty will still be recognized as "/". But usually users will not visit the installation directory of wsltty from the Linux subsystem. Therefore this simple patch is enough for the most cases.

Best regards

@jagd jagd changed the title fix file drag & drop by replacing /cygdrive to /mnt fix file drag & drop by replacing /cygdrive with /mnt Oct 9, 2016
@mintty
Copy link
Owner
mintty commented Oct 9, 2016

The request is accepted but I don't wish to deal with patched versions of mintty.
I'll rather add a command-line option to change the path, or maybe a general "WSL support" option in case other adaptations are identified later (cf. mintty/mintty#558).
Also note that strcpy is in general not defined for overlapping string areas.

@mintty mintty closed this Oct 9, 2016
@mintty
Copy link
Owner
mintty commented Oct 11, 2016

Also, the path must not be adapted for all invocations of path_win_w_to_posix but only for the drag-and-drop use case, handled in winclip.c.

@mintty
Copy link
Owner
mintty commented Nov 18, 2016

Released 0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0