Error ls remote #351
Merged
Error ls remote #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide PKT-line and use p_http_report_status in TCP flow (wip)
|
with ke and encore from master each, I run into: File "src/git/smart.ml", line 1183, characters 10-72:
Error: This expression has type ('a, [> Rresult.R.msg ] as 'b) result state
but an expression was expected of type Common.advertised_refs state
Type ('a, 'b) result is not compatible with type
Common.advertised_refs when attempting to compile this... (edit: CI says same) |
… repository or a repository where we did not have rights
9249ede to
08e5082
Compare
|
Fixed sorry for the noise. |
|
ok, tests with this PR (08e5082 and ke & encore from their master branches):
|
|
(NB, if https and no proper user + password (the above one was using a user+pass in the url which I removed from the output manually): |
|
Yes the last one bug is the big and final boss 👍 |
…vior from TCP impl.)
…got [None], it notices end of input)
|
I just want to say, all of these bugs come from only one problem: a non existing documentation about the Smart protocol |
0caa6d8 to
067371f
Compare
|
ok, with 067371f:
so it seems the success answer for https/smart-http needs to be parsed more politely... |
…want to discover references
|
I cherry-pick commit from @clecat when it fits under the topic of this PR. I will add some regression tests to this PR. It will take a time 8000 when it's not easy to mimic a Git server but I found a way to do that properly. |
…ic world without unicorn and this test works!
|
nice tests! :) |
|
I need to write the last tests about @clecat fix and it's ready to merge. These tests does not cover HTTP however ... Simulate an HTTP flow is little bit annoying. Good news. this test check some assertions about |
|
The last regression test fails, as expected, in master and works in this PR. Waiting CI and ready to merge. |
This was referenced Apr 10, 2019
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jul 12, 2019
CHANGES: - Move to the last version of `decompress` (@dinosaure, mirage/ocaml-git#366) - Check order of entries in a tree object (bug found by @samoht, fixed by @dinosaure, mirage/ocaml-git#365) - Use `mmap` package (@dinosaure, mirage/ocaml-git#347, mirage/ocaml-git#360) - Update README.md (@tcoopman, @dinosaure, mirage/ocaml-git#337, mirage/ocaml-git#359) - `trim` the window used to pack (@pqwy, @dinosaure, mirage/ocaml-git#357, mirage/ocaml-git#358) - Use lastest version of `lru.0.3.0` (@pqwy, @dinosaure, mirage/ocaml-git#352, mirage/ocaml-git#356) - Fix smart protocol (fixed by @clecat and @dinosaure, feedbacks from @hannesm) * Pull-request mirage/ocaml-git#351, mirage/ocaml-git#350, mirage/ocaml-git#338 * Issues mirage/ocaml-git#335, mirage/ocaml-git#342, mirage/ocaml-git#346 + regression tests was added (@dinosaure) + semantics about negociation was explained (@clecat) + end-to-end tests partially done (@hannesm) - Remove `sexplib` dependency (@samoht, mirage/ocaml-git#349) - Fix smart protocol to accept empty response from `ls-remote` (bug found by @hannesm, fixed by @dinosaure, mirage/ocaml-git#348) - Add `io-page-unix` as dependency to tests `git-mirage` (@dinosaure, mirage/ocaml-git#345) - Remove deprecated `Cstruct.add_len` (replaced by `ke`) (@dinosaure, mirage/ocaml-git#345) - Use `Uri.user_info` to be able to be authentified by a service like GitHub (@linse, review by @dinosaure, mirage/ocaml-git#341, mirage/ocaml-git#343) - avoid clash between `digestif.c` and `digestif.ocaml` implementation (same for `checkseum`) * remove implementation dependencies on `git-unix` and `git-mirage` (bug found by @hannesm and @linse, fixed by @dinosaure, mirage/ocaml-git#339) This update should be fixed by `dune`'s variants and `>= digestif.0.7.2` and `>= checkseum.0.1.0` - **breaking-change** add `etmp` as already-allocated buffer to encode Git object (@dinosaure, mirage/ocaml-git#336) * add `ke.0.3` as new dependency - consumed inputs for every entries in a tree (bug found by @zspicko, fixed by @dinosaure, mirage/ocaml-git#334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #350 to handle, this time, error when we want to clone/push/pull/ls-remote a non-existing git repository or a repository where we did not have right.