Fix build for angstrom 0.14.0 #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8000
|
angstrom 0.14.0 is out on OPAM now, might be worth to re run the CI. |
|
I think we can use |
Add ~consume:Prefix argument to parse_string and parse_bigstring. This achieves the old behavior of the two functions.
|
Rebased to change that. Was a bit worried this might cause problems because of your comment in |
Yes, it's another issue but it should be fine, thanks. I will prepare a release of |
|
Awesome :) |
Closed
|
Sorry for the delay. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jun 30, 2020
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 8, 2021
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 8, 2021
CHANGES: - Move to `encoder.0.5` (mirage/ocaml-git#393, @dinosaure) - Move to `angstrom.0.14.0` (mirage/ocaml-git#384, @sternenseemann) - Add missing Time argument to `Resolver_mirage.Make_with_stack` (mirage/ocaml-git#389, @talex5) - Fix .ocamlformat file (mirage/ocaml-git#389, @talex5) - Enlarge internal buffer used to parse Git object (mirage/ocaml-git#389, @dinosaure) - Update README.md (mirage/ocaml-git#383, @dinosaure) - Use `mirage-crypto` instead `nocrypto` (mirage/ocaml-git#382, @hannesm) - Add constraint on `dune` package (@kit-ty-kate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
~consume:Prefixargument toparse_stringandparse_bigstring.This achieves the old behavior of the two functions.