add one click enroll functionality to dashboard cards #2319
Conversation
49d04f3 to
564bde9
Compare
There was a problem hiding this comment.
Looks good and thanks @gumaerc for helping me get set up to fuel this locally.
Some observations:
- In the
mitxonlineEnrollment()transform we get the status from the grades https://github.com/mitodl/mit-learn/pull/2319/files#diff-e27375eac7f9200d6414e93f9318b1314ba646ed3045910b06f7cc6896ae9dd8R45-R47
status: raw.grades[0]?.passed
? EnrollmentStatus.Completed
: EnrollmentStatus.Enrolled,
The status is therefore never EnrollmentStatus.NotEnrolled as the new logic sometimes expects.
- If I set the course run enrollment to anything other than
enrolledin the mitxonline admin e.g. http://mitxonline.odl.local:8013/admin/courses/courserunenrollment/1/change/, I do not see any change from the enrollments endpoint (http://mitxonline.odl.local:8065/api/v1/enrollments/) to determine the status.
| const hasStarted = startDate && isInPast(startDate) | ||
| const notEnrolled = |
There was a problem hiding this comment.
Small request for
const hasEnrolled = enrollmentStatus &&
enrollmentStatus !== EnrollmentStatus.NotEnrolled
There was a problem hiding this comment.
You are indeed correct that enrollment.status is currently never explicitly set to EnrollmentStatus.NotEnrolled. The check for the status at all is there because unenrolled courses come from mitxonlineUnenrolledCourse() (also in transform.ts) and do not get enrollment set on them at all, hence the check for it being not set. Overall I think the logic makes more sense this way though, so I changed it.
There was a problem hiding this comment.
Got it - DashboardCard is also used in OrganizationContent.tsx and fed by the queries there 👍
564bde9 to
0df64c3
Compare
|
@jonkafton Thanks for your review, this is ready for another look. I also updated the default for the MITx Online CSRF token name, as it was changed in MITx Online in mitodl/mitxonline#2762 |
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/7651
Description (What does it do?)
This PR adds the ability to utilize the "one click enroll" B2B API in MITx Online. Cards for courses in
OrganizationContentthat are part of your org but you are not yet enrolled in will have a button that says "Enroll" instead of "Continue Course." Clicking this button enrolls you in the course, after which you can click "Continue Course" as normal.How can this be tested?
In order to test this, you need a basic installation of
mitxonlineup and running with example data in it. You may be able to skip one or more steps if you have already done them:hostsredirects for the following domains, replacing the example IP with your local IP address (Google how to get this if unsure, mine is 192.168.1.50)mitxonline: https://github.com/mitodl/mitxonline.envfile with the following values:mitxonlinewithdocker compose up --build -ddocker compose exec web ./manage.py promote_user --promote --superuser admin@odl.localdocker compose exec web ./manage.py populate_course_datapants docs ::dist/sphinx/index.html, read the section on generating a B2B organization / contract and create one, adding some of the test courses to itProgramand add some courses to the program that are included in your B2B org, making sure to mark the program as "live"mit-learn, we need to set some env variables (note that we are intentionally misconfiguring the cookie domain):enrollment-dashboardandmitlearn-organization-dashboardfeature flags for all usersMIT Learnadmin@odl.localtest user